Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unescape paths in binned timeUnits to allow for fields with periods in name #9088

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

lsh
Copy link
Member

@lsh lsh commented Sep 12, 2023

Currently specs with a period in a field name and binned timeUnit fail due to the escaping logic. This PR unescapes fields with a period in them to allow those visualizations to work.

Please:

  • Make the pull requests (PRs) atomic (fix one issue at a time). Multiple relevant issues that must be fixed together? Make atomic commits so we can easily review each issue.
  • Provide a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties") so we can easily copy it to the release note.
    • Use imperative mood and present tense.
  • Mention relevant issues in the description (e.g., Fixes #1 / Fixes part of #1).
  • Lint and test (Run yarn test).
  • Review your changes before sending the PR (to ensure code quality).
  • For new features:
    • Add new unit tests.
    • Update the documentation under site/docs/ + add examples.

Tips:

@lsh lsh requested a review from kanitw September 12, 2023 18:20
@kanitw kanitw merged commit 53ede0e into main Sep 12, 2023
9 checks passed
@kanitw kanitw deleted the lsh/binned-timeunit-fix branch September 12, 2023 22:54
alliefeldman pushed a commit to alliefeldman/vega-lite that referenced this pull request Oct 2, 2023
…riods in name (vega#9088)

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
…riods in name (vega#9088)

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants